add systemd build tag to podman builds #5683
Conversation
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @larsks. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
openshift-ci-robot
added
ok-to-test
approved
|
LGTM |
| @@ -392,7 +392,7 @@ popd | |||
| ln -s vendor src | |||
| export GO111MODULE=off | |||
| export GOPATH=$(pwd)/_build:$(pwd):$(pwd):%{gopath} | |||
| export BUILDTAGS="varlink selinux seccomp $(%{hackdir}/hack/btrfs_installed_tag.sh) $(%{hackdir}/hack/btrfs_tag.sh) $(%{hackdir}/hack/libdm_tag.sh) exclude_graphdriver_devicemapper" | |||
| export BUILDTAGS="varlink selinux seccomp systemd $(%{hackdir}/hack/btrfs_installed_tag.sh) $(%{hackdir}/hack/btrfs_tag.sh) $(%{hackdir}/hack/libdm_tag.sh) exclude_graphdriver_devicemapper" | |||
There was a problem hiding this comment.
May be we can use this script https://github.com/containers/libpod/blob/master/hack/systemd_tag.sh ?
There was a problem hiding this comment.
I refer you to the commit message, in which I explain exactly why I am not doing that.
There was a problem hiding this comment.
Ah, commit message commit explains it, thanks :-)
Without the systemd build tag, podman will fail with the error "No support for journald logging". This commit adds the `systemd` build tag explicitly, rather than relying on `hack/systemd_tag.sh` (because we're building an rpm and we've explicitly included systemd-devel as a dependency). Signed-off-by: Lars Kellogg-Stedman <lars@redhat.com>
larsks
force-pushed
the
bug/rpm-systemd-tag
branch
from
21441e7
to
2753df2
Compare
|
/approve |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, larsks, mheon, raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Without the systemd build tag, podman will fail with the error "No
support for journald logging".
This commit adds the
systemdbuild tag explicitly, rather thanrelying on
hack/systemd_tag.sh(because we're building an rpm andwe've explicitly included systemd-devel as a dependency).