Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

Initial plumbing for releasing lease #35

Merged
merged 1 commit into from Nov 23, 2022

Conversation

baude
Copy link
Member

@baude baude commented Nov 21, 2022

The DHCP RFCs state that a DHCPRELEASE message should be passed in most cases when a client is done. This adds some plumbing so that development can continue and netavark development can also continue.

Signed-off-by: Brent Baude bbaude@redhat.com

@mheon
Copy link
Member

mheon commented Nov 22, 2022

LGTM

src/dhcp_service.rs Outdated Show resolved Hide resolved
src/dhcp_service.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than comments from @Luap99

@openshift-ci
Copy link

openshift-ci bot commented Nov 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The DHCP RFCs state that a DHCPRELEASE message should be passed in most
cases when a client is done.  This adds some plumbing so that
development can continue and netavark development can also continue.

Signed-off-by: Brent Baude <bbaude@redhat.com>
@Luap99
Copy link
Member

Luap99 commented Nov 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 67aad16 into containers:main Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants