Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.0 fails to build on i686 #578

Closed
lsm5 opened this issue Feb 3, 2023 · 10 comments · Fixed by #614
Closed

v1.5.0 fails to build on i686 #578

lsm5 opened this issue Feb 3, 2023 · 10 comments · Fixed by #614

Comments

@lsm5
Copy link
Member

lsm5 commented Feb 3, 2023

Compiling mozim v0.1.0
error[E0277]: the trait bound `i32: From<u32>` is not satisfied
   --> /builddir/build/BUILD/netavark-1.5.0/vendor/mozim/src/socket.rs:289:17
    |
289 |         tv_sec: timeout.into(),
    |                 ^^^^^^^ ---- required by a bound introduced by this call
    |                 |
    |                 the trait `From<u32>` is not implemented for `i32`
    |
    = help: the following other types implement trait `From<T>`:
              <i32 as From<NonZeroI32>>
              <i32 as From<bool>>
              <i32 as From<i16>>
              <i32 as From<i8>>
              <i32 as From<nix::time::ClockId>>
              <i32 as From<nix::unistd::Pid>>
              <i32 as From<socket2::Domain>>
              <i32 as From<socket2::Protocol>>
            and 5 others
    = note: required for `u32` to implement `Into<i32>`
For more information about this error, try `rustc --explain E0277`.
error: could not compile `mozim` due to previous error
warning: build failed, waiting for other jobs to finish...
make: *** [Makefile:50: build] Error 101
error: Bad exit status from /var/tmp/rpm-tmp.sLYjfo (%build)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.sLYjfo (%build)
Child return code was: 1

Looks like an issue in a dependency crate, but that's blocking i686 rpm build.

@Luap99
Copy link
Member

Luap99 commented Feb 3, 2023

Yes this is caused by the mozim crate which is imported by the dhcp proxy.

@Luap99
Copy link
Member

Luap99 commented Feb 3, 2023

@baude PTAL

@baude
Copy link
Member

baude commented Feb 3, 2023

where are we building i686?

@dacioromero
Copy link

dacioromero commented Feb 6, 2023

I cross compile NixOS for my armv7l SBC and I'm having the exact same error after NixOS/nixpkgs#214293 was merged into nixos-unstable.

@lsm5
Copy link
Member Author

lsm5 commented Feb 6, 2023

where are we building i686?

it's still one of the main arches on Fedora. Let me know if you wanna exclusivearch it, but then we'll likely need to do the same for podman, buildah etc.

@Luap99
Copy link
Member

Luap99 commented Feb 6, 2023

I think exclusive arch for fedora is fine, https://fedoramagazine.org/in-fedora-31-32-bit-i686-is-86ed/
There is no i686 kernel so I do not see why anyone would want to run i686 netavark on fedora.

As for actually fixing this needs to be done in the mentioned crate, the only thing we could do in netavark is to revert the dhcp changes which is not something I want to do.

@lsm5
Copy link
Member Author

lsm5 commented Feb 6, 2023

I'll probably need to check with fedora people but I think exclusivearch-ing all of podman family should be doable.

@lsm5
Copy link
Member Author

lsm5 commented Feb 9, 2023

F38 has now been branched. I have disabled i686 and I realized it also fails on armhfp like it did for @dacioromero so I will not update our packages for f36 anymore unless people demand or there are CVEs.

@dacioromero no idea about nixos, but looks like fedora is giving up armhfp support altogether once Fedora 36 goes EOL requiring users to switch to something else come May/June. I can't speak for everyone, but looks like there won't be a ton of time spent on fixing 32-bit issues going forward.

I'm good to close this..

@Luap99
Copy link
Member

Luap99 commented Feb 9, 2023

I reported it upstream (nispor/mozim#11) so I close this one here.
Once fixed we will update the dep here.

@cathay4t
Copy link

Please use mozim 0.2.1 which contains the fix.

Luap99 added a commit to Luap99/netavark that referenced this issue Mar 8, 2023
A fixes for the breaking changes:
- timeout is u32
- DhcpV4Config::new_proxy() no longer return an Result type

This also fixes the build issue on i686.
Fixes containers#578

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
flouthoc pushed a commit to flouthoc/netavark that referenced this issue Apr 24, 2023
A fixes for the breaking changes:
- timeout is u32
- DhcpV4Config::new_proxy() no longer return an Result type

This also fixes the build issue on i686.
Fixes containers#578

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants