aardvark, netavark: support network scoped dns via network_dns_servers
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tests are expected to fail without containers/aardvark-dns#252 |
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Nov 21, 2022
libnetwork must allow to pass network_dns_servers so aardvark and netavark can consume it and enabled network scoped dns. Feature implemented at netavark and aardvark end * Netavark: containers/netavark#497 Signed-off-by: Aditya R <arajan@redhat.com>
This was referenced Nov 21, 2022
Merged
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Nov 21, 2022
libnetwork must allow to pass network_dns_servers so aardvark and netavark can consume it and enabled network scoped dns. Feature implemented at netavark and aardvark end * Netavark: containers/netavark#497 Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Nov 21, 2022
libnetwork must allow to pass network_dns_servers so aardvark and netavark can consume it and enabled network scoped dns. Feature implemented at netavark and aardvark end * Netavark: containers/netavark#497 Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Nov 21, 2022
libnetwork must allow to pass network_dns_servers so aardvark and netavark can consume it and enabled network scoped dns. Feature implemented at netavark and aardvark end * Netavark: containers/netavark#497 Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Nov 21, 2022
libnetwork must allow to pass network_dns_servers so aardvark and netavark can consume it and enabled network scoped dns. Feature implemented at netavark and aardvark end * Netavark: containers/netavark#497 Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
network-scoped-dns-netavark
branch
2 times, most recently
from
42b5872
to
c8a49e6
Compare
Luap99
reviewed
Nov 23, 2022
test/testfiles/dualstack-bridge-network-container-dns-server.json
Outdated
Show resolved
Hide resolved
Aardvark and podman supports `network_dns_servers` which allows aardvark to configure a resolver at network level and all containers attached to a network honors this resolver. Needs: containers/aardvark-dns#252 Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
network-scoped-dns-netavark
branch
from
c8a49e6
to
46f9f59
Compare
|
/lgtm |
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 4, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] [NAME]
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 4, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] [NAME]
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 10, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] [NAME]
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 10, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] [NAME]
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 10, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] [NAME]
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 10, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] [NAME]
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 11, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] [NAME]
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 11, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] [NAME]
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 11, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] [NAME]
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 11, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] [NAME]
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 11, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] [NAME]
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 16, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] [NAME]
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 16, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] NAME
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Dec 16, 2022
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] NAME
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Jan 11, 2023
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] NAME
Examples:
podman network update podman1
Options:
--add-dns-servers stringArray add network level nameservers
--remove-dns-servers stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Jan 12, 2023
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] NAME
Examples:
podman network update podman1
Options:
--dns-add stringArray add network level nameservers
--dns-drop stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Jan 12, 2023
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] NAME
Examples:
podman network update podman1
Options:
--dns-add stringArray add network level nameservers
--dns-drop stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Jan 12, 2023
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] NAME
Examples:
podman network update podman1
Options:
--dns-add stringArray add network level nameservers
--dns-drop stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Jan 12, 2023
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] NAME
Examples:
podman network update podman1
Options:
--dns-add stringArray add network level nameservers
--dns-drop stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Jan 12, 2023
* Add support for `podman network update <>`
```console
network update
Description:
update networks for containers and pods
Usage:
podman network update [options] NAME
Examples:
podman network update podman1
Options:
--dns-add stringArray add network level nameservers
--dns-drop stringArray remove network level nameservers
```
* Add support for `--network-dns-server` to `podman network create`
Extends podman to support recently added features in `netavark` and
`aardvark-dns`
* containers/netavark#497
* containers/aardvark-dns#252
* containers/netavark#503
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Signed-off-by: Aditya R <arajan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aardvark and podman supports
network_dns_serverswhich allows aardvark to configure a resolver at network level and all containers attached to a network honors this resolver.Needs: containers/aardvark-dns#252