Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gobpf: fix compatibility with bcc v0.25.0 #104

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

martinetd
Copy link
Contributor

bcc v0.25.0 broke compatibility with bcc_func_load and requires updating the gobpf wrapper.

Fixes: #100
Signed-off-by: Dominique Martinet asmadeus@codewreck.org


not 100% sure I did this right but the vendored diff looks right, so I'll pretend it works.
I didn't test any of this yet (hoping some CI will test current bcc version at least), I can try with bcc 0.25 on nixos but honestly no idea how to actually test the hooks I'm just doing this for NixOS/nixpkgs#189078 update

bcc v0.25.0 broke compatibility with bcc_func_load and requires updating
the gobpf wrapper.

Fixes: containers#100
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks have passed, thanks @martinetd!

@giuseppe PTAL

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to build with current bcc
3 participants