Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide the setter method #77

Closed
utam0k opened this issue Oct 5, 2021 · 4 comments
Closed

Provide the setter method #77

utam0k opened this issue Oct 5, 2021 · 4 comments
Labels
good first issue Good for newcomers

Comments

@utam0k
Copy link
Member

utam0k commented Oct 5, 2021

Make the setter method available as a library.
Some of them already provide setter methods. We will use this PR as a model to provide setter methods for other structures as well.
#76
@utam0k utam0k added the good first issue Good for newcomers label Oct 5, 2021
@utam0k utam0k mentioned this issue Oct 5, 2021
Merged
@TristanCacqueray
Copy link
Contributor

I'd like to give this a try, should the setters be added to all the structs?

TristanCacqueray added a commit to TristanCacqueray/oci-spec-rs that referenced this issue Oct 14, 2021
@TristanCacqueray
Add missing setters for structs
a5f3bc9 
Related to containers#77
@TristanCacqueray TristanCacqueray mentioned this issue Oct 14, 2021
Merged
@saschagrunert
Copy link
Member

I'd like to give this a try, should the setters be added to all the structs?

Yep, for consistency reasons.

TristanCacqueray added a commit to TristanCacqueray/oci-spec-rs that referenced this issue Oct 15, 2021
@TristanCacqueray
Add missing setters for structs
99ab2f5 
Related to containers#77
@utam0k
Copy link
Member Author

utam0k commented Oct 16, 2021

Special thanks to @TristanCacqueray

@utam0k utam0k closed this as completed Oct 16, 2021
@TristanCacqueray
Copy link
Contributor

You are welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TristanCacqueray @saschagrunert @utam0k