Remove redundant spec values #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 26.88% 27.10% +0.22%
==========================================
Files 7 7
Lines 491 487 -4
Branches 248 244 -4
==========================================
Hits 132 132
+ Misses 130 129 -1
+ Partials 229 226 -3 |
|
|
||
| #[cfg_attr(feature = "builder", getset(get_copy = "pub"))] | ||
| // TODO: I am not part of the official spec | ||
| freezer: Option<FreezerState>, |
There was a problem hiding this comment.
Do we wanna remove the FreezerState type too?
There was a problem hiding this comment.
Yes, this should have been removed. The runtime spec does not say anything about the freezer.
saschagrunert
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17 . Disable_oom_killer and oom_score_adj were already part of the memory and process sections, so there was nothing to add.