Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users if they are using a podman machine with few resources #227

Closed
2 tasks done
lstocchi opened this issue Feb 5, 2024 · 7 comments
Closed
2 tasks done

Warn users if they are using a podman machine with few resources #227

lstocchi opened this issue Feb 5, 2024 · 7 comments
Labels
kind/epic Issue describing an epic
Milestone

Comments

@lstocchi
Copy link
Contributor

lstocchi commented Feb 5, 2024

It may happen that users want to play with ai-studio but they have a machine with few resources.
We should show a warning somewhere to explain that having less than Y GB and X CPUs could make the recipe run extremely slow and it is recommended to create a new machine with more resources.

@axel7083
Copy link
Contributor

axel7083 commented Feb 5, 2024

From my understanding, we had a mockup for that @mairin

And we do not need to create a new machine I think we can increase an existing with the following comment containers/podman#12713 (comment))

I did not test it

@mairin
Copy link
Member

mairin commented Feb 9, 2024

Yep you are right @axel7083 here is the mockup:

Recipe Catalog - Podman machine warning

@axel7083
Copy link
Contributor

axel7083 commented Feb 9, 2024

Now the issue, if that we don't know what to do when the user click on Upgrade as we do not have apis, nor ways to upgrade it on the extension side

We might want to redirect the user to the podman machine config ?

cc @benoitf maybe you have an opinion/pov ?

@benoitf
Copy link
Collaborator

benoitf commented Feb 9, 2024

  • short term you could parse or invoke podman machine list command, podman machine stop/set/start command (do the job of the podman extension)

  • mid term: use an exported API of Podman extension (Ai-studio will have a dependency to podman extension and can then exchange directly with it without duplicating the code)

@jeffmaury
Copy link
Contributor

Such a check should be present in various places of the AI Studio UI

@vrothberg
Copy link
Member

I closed #502 in favor of this issue but moved it over the 1.0 milestone.

@lstocchi lstocchi self-assigned this Apr 3, 2024
lstocchi added a commit to lstocchi/studio-extension that referenced this issue Apr 9, 2024
…esources (containers#227)

Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi added a commit to lstocchi/studio-extension that referenced this issue Apr 9, 2024
…esources (containers#227)

Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi added a commit to lstocchi/studio-extension that referenced this issue Apr 10, 2024
…esources (containers#227)

Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi added a commit to lstocchi/studio-extension that referenced this issue Apr 10, 2024
…esources (containers#227)

Signed-off-by: lstocchi <lstocchi@redhat.com>
@jeffmaury jeffmaury added the kind/epic Issue describing an epic label Apr 11, 2024
lstocchi added a commit to lstocchi/studio-extension that referenced this issue Apr 11, 2024
…esources (containers#227)

Signed-off-by: lstocchi <lstocchi@redhat.com>
jeffmaury pushed a commit to lstocchi/studio-extension that referenced this issue Apr 12, 2024
…esources (containers#227)

Signed-off-by: lstocchi <lstocchi@redhat.com>
jeffmaury pushed a commit to lstocchi/studio-extension that referenced this issue Apr 12, 2024
…esources (containers#227)

Signed-off-by: lstocchi <lstocchi@redhat.com>
jeffmaury added a commit that referenced this issue Apr 12, 2024
…esources (#227) (#856)

* feat: show warning if no machine is running or there are not enough resources (#227)

Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Co-authored-by: Jeff MAURY <jmaury@redhat.com>
@lstocchi
Copy link
Contributor Author

Closing this as both issues have been completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic Issue describing an epic
Projects
Status: ✔️ Done
Development

No branches or pull requests

7 participants