Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: forbid creating several playgrounds with the same name #1016

Merged
merged 5 commits into from
Apr 30, 2024
Merged

fix: forbid creating several playgrounds with the same name #1016

merged 5 commits into from
Apr 30, 2024

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Apr 29, 2024 •
edited

What does this PR do?

Raise an error when the user creates a playground with a name already used by another playground.

Screenshot / video of UI

playground-same-name.mp4

What issues does this PR fix or reference?

Fix #782

How to test this PR?

  • Create a first playground
  • try to create a second playground with the same name

@feloy feloy requested review from benoitf and a team as code owners April 29, 2024 12:22
@feloy feloy requested a review from axel7083 April 29, 2024 12:22
@feloy feloy force-pushed the fix-782/playground-same-name branch from 182aab2 to e81476b Compare April 29, 2024 12:23
@feloy feloy marked this pull request as draft April 29, 2024 12:28
@feloy feloy force-pushed the fix-782/playground-same-name branch from 3d46fc8 to 1c9a3dc Compare April 29, 2024 13:14
@feloy feloy marked this pull request as ready for review April 29, 2024 13:21
axel7083
axel7083 reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@axel7083 axel7083 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a weird feeling with isFreeName I am not a native english speaker so I might be wrong, but I feel like isNameFree sound better

@feloy feloy requested a review from axel7083 April 29, 2024 16:29
feloy and others added 5 commits April 29, 2024 18:40
@feloy
fix: forbid creating several playgrounds with the same name
708c75f 
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy
tests: add unit test
e4981d0 
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy
re-enable submit button when error occurs
3a772ea 
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy @axel7083
Update packages/backend/src/managers/playgroundV2Manager.ts
a79b0fe 
Co-authored-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: Philippe Martin <feloy1@gmail.com>
@feloy
fix: rename isFreeName -> isNameFree
115d536 
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy force-pushed the fix-782/playground-same-name branch from 2d0db3b to 115d536 Compare April 29, 2024 16:40
axel7083
axel7083 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 ! Thanks for the changes!

@feloy feloy merged commit 7595c87 into containers:main Apr 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axel7083 axel7083 axel7083 approved these changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It is possible to create 2 playgrounds with the same name
2 participants
@feloy @axel7083