Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove system prompt from playground creation page #1020

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Apr 30, 2024

What does this PR do?

Remove the system prompt input from playground creation page. The system prompt is still settable from the playground page.

Screenshot / video of UI

no-system-prompt

What issues does this PR fix or reference?

Fix #660

How to test this PR?

Create a playground and check the system prompt can be set after creation time

Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy requested review from benoitf and a team as code owners April 30, 2024 05:38
@feloy feloy requested a review from axel7083 April 30, 2024 05:38
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for cleaning the api also !

@feloy feloy merged commit ab0caf4 into containers:main Apr 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove system prompt from playground creation page
2 participants