Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: playground improvements for keyboard usage #946

Merged
merged 4 commits into from
May 3, 2024
Merged

fix: playground improvements for keyboard usage #946

merged 4 commits into from
May 3, 2024

Conversation

jeffmaury
Copy link
Contributor

@jeffmaury jeffmaury commented Apr 22, 2024 •
edited by lstocchi

Fixes #839

What does this PR do?

Gives focus to the prompt and handle Enter key

Screenshot / video of UI

playground_enter

What issues does this PR fix or reference?

#839

How to test this PR?

  1. Create a playground
  2. Enter text + enter => should send the request

@jeffmaury
fix: playground improvements for keyboard usage
0bf17dd 
Fixes containers#839

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury requested review from benoitf and a team as code owners April 22, 2024 13:08
@jeffmaury jeffmaury requested a review from lstocchi April 22, 2024 13:08
@benoitf
Copy link
Collaborator

benoitf commented Apr 22, 2024

to me it fixes the keyboard issue but the layout is still not the expected one

I expect the button being part of the widget and being centered and not attached to the left

image

benoitf
benoitf approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@benoitf benoitf left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but don't know if we can call it fixes #839

@jeffmaury
fix: update prompt button
de5d4a0 
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@benoitf
Copy link
Collaborator

benoitf commented Apr 26, 2024

on my side the prompt is the same color than the background

image

@lstocchi
fix: update text color to white
40f171f 
Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi
lstocchi reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my case, when i click Enter, the message is sent correctly but then there is an active new line in the textarea that prevents the plaholder to be seen.

@lstocchi
fix: avoid adding newline after playground message is sent
243df72 
Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested a review from benoitf April 29, 2024 08:05
@lstocchi
Copy link
Contributor

@benoitf Jeff asked me to fix this as he's on PTO. If it looks good for you we can merge

@lstocchi
Copy link
Contributor

In my case, when i click Enter, the message is sent correctly but then there is an active new line in the textarea that prevents the plaholder to be seen.

fixed

@benoitf
Copy link
Collaborator

benoitf commented Apr 29, 2024

@lstocchi yes, probably need to update the screenshot/gif of the PR body

@lstocchi
Copy link
Contributor

lstocchi commented May 3, 2024

@benoitf updated
Sorry, i always forgot 😵‍💫

@benoitf benoitf merged commit b4c4198 into containers:main May 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lstocchi lstocchi lstocchi left review comments

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playground improvements for keyboard usage
3 participants
@jeffmaury @benoitf @lstocchi