Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding imported tab in models page #981

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

axel7083
Copy link
Contributor

What does this PR do?

Adding an imported tab to models page for imported models.

Screenshot / video of UI

imported-models-tab.mp4

What issues does this PR fix or reference?

Fixes #944

How to test this PR?

  • unit tests cover this feature

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm, great work!

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested a review from jeffmaury April 25, 2024 16:40
{#if importedModels.length > 0}
<Table kind="model" data="{importedModels}" columns="{columns}" row="{row}"></Table>
{:else}
<div role="status">There are no models yet</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure which expression is correct, but this one is different from the one in other tabs ('There is no model yet')

@axel7083 axel7083 merged commit 1360863 into containers:main Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

models page should have an _imported_ tab
4 participants