fix: edit Podman machine support for MacOS only

Fixes #5233 Signed-off-by: Jeff MAURY <jmaury@redhat.com>
containers · Dec 13, 2023 · 7df41e2 · 7df41e2
1 parent a298dcd
commit 7df41e2
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/extensions/podman/src/extension.ts b/extensions/podman/src/extension.ts
@@ -606,7 +606,10 @@ async function registerProviderFor(provider: extensionApi.Provider, machineInfo:
     delete: async (logger): Promise<void> => {
       await extensionApi.process.exec(getPodmanCli(), ['machine', 'rm', '-f', machineInfo.name], { logger });
     },
-    edit: async (context, params, logger, _token): Promise<void> => {
+  };
+  //support edit only on MacOS as Podman WSL is nop and generates errors
+  if (isMac()) {
+    lifecycle.edit = async (context, params, logger, _token): Promise<void> => {
       let effective = false;
       const args = ['machine', 'set', machineInfo.name];
       for (const key of Object.keys(params)) {
@@ -636,8 +639,8 @@ async function registerProviderFor(provider: extensionApi.Provider, machineInfo:
           }
         }
       }
-    },
-  };
+    };
+  }
 
   const containerProviderConnection: extensionApi.ContainerProviderConnection = {
     name: prettyMachineName(machineInfo.name),