fix: check if machine init rootful flag supported

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
containers · Sep 10, 2023 · fdb194f · fdb194f
1 parent 18ecd16
commit fdb194f
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 2 deletions.
diff --git a/extensions/podman/package.json b/extensions/podman/package.json
@@ -104,7 +104,8 @@
           "type": "boolean",
           "default": true,
           "scope": "ContainerProviderConnectionFactory",
-          "description": "Machine with root privileges"
+          "description": "Machine with root privileges",
+          "when": "podman.isRootfulMachineInitSupported == true"
         },
         "podman.factory.machine.user-mode-networking": {
           "type": "boolean",

diff --git a/extensions/podman/src/extension.ts b/extensions/podman/src/extension.ts
@@ -659,6 +659,7 @@ async function registerUpdatesIfAny(
   }
 }
 
+export const ROOTFUL_MACHINE_INIT_SUPPORTED_KEY = 'podman.isRootfulMachineInitSupported';
 export const USER_MODE_NETWORKING_SUPPORTED_KEY = 'podman.isUserModeNetworkingSupported';
 
 export async function activate(extensionContext: extensionApi.ExtensionContext): Promise<void> {
@@ -669,6 +670,7 @@ export async function activate(extensionContext: extensionApi.ExtensionContext):
   const version: string | undefined = installedPodman?.version;
 
   if (version) {
+    extensionApi.context.setValue(ROOTFUL_MACHINE_INIT_SUPPORTED_KEY, isRootfulMachineInitSupported(version));
     extensionApi.context.setValue(USER_MODE_NETWORKING_SUPPORTED_KEY, isUserModeNetworkingSupported(version));
   }
 
@@ -1072,6 +1074,13 @@ export async function deactivate(): Promise<void> {
   });
 }
 
+const PODMAN_MINIMUM_VERSION_FOR_ROOTFUL_MACHINE_INIT = '4.1.0';
+
+// Checks if rootful machine init is supported.
+export function isRootfulMachineInitSupported(podmanVersion: string) {
+  return compareVersions(podmanVersion, PODMAN_MINIMUM_VERSION_FOR_ROOTFUL_MACHINE_INIT) >= 0;
+}
+
 const PODMAN_MINIMUM_VERSION_FOR_USER_MODE_NETWORKING = '4.6.0';
 
 // Checks if user mode networking is supported. Only Windows platform allows this parameter to be tuned

diff --git a/extensions/podman/src/podman-install.ts b/extensions/podman/src/podman-install.ts
@@ -29,7 +29,12 @@ import { getAssetsFolder } from './util';
 import { getDetectionChecks } from './detection-checks';
 import { BaseCheck } from './base-check';
 import { MacCPUCheck, MacMemoryCheck, MacPodmanInstallCheck, MacVersionCheck } from './macos-checks';
-import { isUserModeNetworkingSupported, USER_MODE_NETWORKING_SUPPORTED_KEY } from './extension';
+import {
+  isRootfulMachineInitSupported,
+  ROOTFUL_MACHINE_INIT_SUPPORTED_KEY,
+  isUserModeNetworkingSupported,
+  USER_MODE_NETWORKING_SUPPORTED_KEY,
+} from './extension';
 
 const readFile = promisify(fs.readFile);
 const writeFile = promisify(fs.writeFile);
@@ -132,6 +137,10 @@ export class PodmanInstall {
       // write podman version
       if (newInstalledPodman) {
         this.podmanInfo.podmanVersion = newInstalledPodman.version;
+        extensionApi.context.setValue(
+          ROOTFUL_MACHINE_INIT_SUPPORTED_KEY,
+          isRootfulMachineInitSupported(newInstalledPodman.version),
+        );
         extensionApi.context.setValue(
           USER_MODE_NETWORKING_SUPPORTED_KEY,
           isUserModeNetworkingSupported(newInstalledPodman.version),
@@ -181,6 +190,10 @@ export class PodmanInstall {
         provider.updateDetectionChecks(getDetectionChecks(installedPodman));
         provider.updateVersion(updateInfo.bundledVersion);
         this.podmanInfo.ignoreVersionUpdate = undefined;
+        extensionApi.context.setValue(
+          ROOTFUL_MACHINE_INIT_SUPPORTED_KEY,
+          isRootfulMachineInitSupported(updateInfo.bundledVersion),
+        );
         extensionApi.context.setValue(
           USER_MODE_NETWORKING_SUPPORTED_KEY,
           isUserModeNetworkingSupported(updateInfo.bundledVersion),