Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection of the extension items in the list in settings is misplaced #2130

Closed
odockal opened this issue Apr 18, 2023 · 1 comment
Closed

Selection of the extension items in the list in settings is misplaced #2130

odockal opened this issue Apr 18, 2023 · 1 comment
Assignees
@deboer-tim
Labels
area/settings ⚙️ area/ui good first issue 🧁 Good for newcomers kind/bug 🐞 Something isn't working
Milestone
0.15.0

Comments

@odockal
Copy link
Contributor

odockal commented Apr 18, 2023 •
edited
Loading

Bug description

When I select the extension item in Settings -> Extensions the selection tile is placed on different extension item.
pd-extensions-select

Operating system

Windows 10 Professional

Version

0.14.1

Steps to reproduce

See the recording. Condition is that windows is not maximized.

Relevant log output

No response

Additional context

No response
@nichjones1 nichjones1 added this to the 0.15.0 milestone Apr 19, 2023
deboer-tim added a commit that referenced this issue Apr 25, 2023
@deboer-tim
feat: Sort extensions
f4726d2 
Extensions should be sorted in both the Settings > Extensions page and in the child list by their display name. This incidentally fixes issue #2130, which was caused by the children being out of order alphabetically.

While fixing this I reduced the font weight of the extension child items to match the Setting > Preferences children in the navigation (and verified with mairin).

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim mentioned this issue Apr 25, 2023
Merged
deboer-tim added a commit that referenced this issue Apr 25, 2023
@deboer-tim
feat: Sort extensions
4a0c386 
Extensions should be sorted in both the Settings > Extensions page and in the child list by their display name. This incidentally fixes issue #2130, which was caused by the children being out of order alphabetically.

While fixing this I reduced the font weight of the extension child items to match the Setting > Preferences children in the navigation (and verified with mairin).

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim
Copy link
Collaborator

Fixed via PR #2221, extensions are now sorted alphabetically and selection works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deboer-tim deboer-tim

Labels
area/settings ⚙️ area/ui good first issue 🧁 Good for newcomers kind/bug 🐞 Something isn't working
Projects
Podman Desktop Planning
Archived in project
Milestone
0.15.0
Development

No branches or pull requests
3 participants
@odockal @deboer-tim @nichjones1