Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty container/kubernetes resources message for podman and kind #2839

Closed
benoitf opened this issue Jun 13, 2023 · 1 comment · Fixed by #3013
Closed

Add empty container/kubernetes resources message for podman and kind #2839

benoitf opened this issue Jun 13, 2023 · 1 comment · Fixed by #3013

Comments

@benoitf
Copy link
Collaborator

benoitf commented Jun 13, 2023

Is your enhancement related to a problem? Please describe

We added in the API 'empty message'

But for example it's only used by DevSandbox extension
image

Describe the solution you'd like

Add message in Podman and Kind

Describe alternatives you've considered

No response

Additional context

No response

@mairin
Copy link
Member

mairin commented Jun 14, 2023

Would be good to use this area for displaying a warning if we cannot contact network for extensions that require network access including:

@cdrage cdrage self-assigned this Jun 26, 2023
cdrage added a commit to cdrage/podman-desktop that referenced this issue Jun 26, 2023
### What does this PR do?

* Adds descriptions for empty connections for both kind and podman.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#2839

### How to test this PR?

`yarn watch`

Look at Settings -> Resources

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/podman-desktop that referenced this issue Jun 26, 2023
### What does this PR do?

* Adds descriptions for empty connections for both kind and podman.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#2839

### How to test this PR?

`yarn watch`

Look at Settings -> Resources

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit that referenced this issue Jun 26, 2023
### What does this PR do?

* Adds descriptions for empty connections for both kind and podman.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes #2839

### How to test this PR?

`yarn watch`

Look at Settings -> Resources

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
mairin pushed a commit to mairin/podman-desktop that referenced this issue Jul 7, 2023
### What does this PR do?

* Adds descriptions for empty connections for both kind and podman.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#2839

### How to test this PR?

`yarn watch`

Look at Settings -> Resources

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants