New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When installing an extension that has an undefined displayName the extensions section gets broken #2871
Comments
maybe we should prevent the loading of the extension (or the installation) |
I was just going to give extensions a default name like "Unknown", and maybe a description too b/c the UI looks odd. But yes, we could refuse to install extensions unless they have a default set of configuration. Maybe name/displayName/description/version/publisher? |
Yeah better, another problem was that i could not stop/remove the extension. And i guess it was due to another missing property. |
yes, let's avoid any unexpected behaviour. Fail fast (no load or install) |
created also #2880 |
Stopping extension install when there are missing attributes: easy, 1 min. UI gives no feedback if the install fails: may take slightly longer. :) |
This changes analyzeExtension() to reject the Promise if there is an error loading an extension (no manifest or missing required attributes), instead of returning undefined. The main reason for the change is to allow error messages to be propagated back to the client (e.g. UI). The remaining changes are handling this in all the places that call analyzeExtension(). IMHO most are more readable and handle error cases cleaner after this change, but for lines 267/272/286 I tried several options and couldn't find anything better than adding '.catch(() => undefined))).' Fixes containers#2871. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Bug description
If an extension does not have a display name the extensions section is broken.
It fails at
Operating system
Windows 11
Installation Method
None
Version
next (development version)
Steps to reproduce
Relevant log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: