Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo: Seal icon for demos / easter egg #3307

Closed
cdrage opened this issue Jul 21, 2023 · 3 comments
Closed

Demo: Seal icon for demos / easter egg #3307

cdrage opened this issue Jul 21, 2023 · 3 comments
Assignees
@deboer-tim
Labels
area/demo 🕺 kind/enhancement ✨ Issue for requesting an improvement

Comments

@cdrage
Copy link
Contributor

cdrage commented Jul 21, 2023

Is your enhancement related to a problem? Please describe

With #3131 being merged in, let's add a hidden easter egg using a demo extension that will add the seal icon for containers containing a certain label. It'll be nice to show the "example" feature.

Describe the solution you'd like

Seal icon + demo extension + documetation.

Describe alternatives you've considered

No response

Additional context

No response
@cdrage cdrage added the kind/enhancement ✨ Issue for requesting an improvement label Jul 21, 2023
@deboer-tim
Copy link
Collaborator

I was learning what we had done for contexts by trying to mark the infra/pause container, when I realized I had basically implemented this already...

Any suggestion on what the label should be? We only look at the key (not value), so was thinking something like LABEL io.podman.demo=awesome?

@deboer-tim deboer-tim self-assigned this Sep 11, 2023
@cdrage
Copy link
Contributor Author

cdrage commented Sep 11, 2023

I was learning what we had done for contexts by trying to mark the infra/pause container, when I realized I had basically implemented this already...

Any suggestion on what the label should be? We only look at the key (not value), so was thinking something like LABEL io.podman.demo=awesome?

I think that'd be a good label name! It's be "unique" enough someone won't accidentally use it.

deboer-tim added a commit that referenced this issue Sep 13, 2023
@deboer-tim
feat: Podman icon
2841dc0 
Adds a Podman icon (woff2 font with only one character, the seal) and
uses it to set a custom icon for any container with the 'io.podman.demo'
label.

For now this is just an easter egg, but it's a start to using the podman
icon elsewhere in the future. (podman-pause infra containers? status-bar
actions?)

Fixes #3307.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim mentioned this issue Sep 13, 2023
Merged
@nichjones1 nichjones1 added this to the 1.6.0 milestone Nov 9, 2023
@nichjones1 nichjones1 removed this from the 1.6.0 milestone Nov 29, 2023
deboer-tim added a commit to redhat-developer/podman-desktop-demo that referenced this issue Jan 26, 2024
@deboer-tim
feat: podman icon
925516c 
Just implements the easter egg suggested in containers/podman-desktop#3307.

The frontend is marked with a label, which customizes it with a
Podman icon.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim mentioned this issue Jan 26, 2024
Merged
deboer-tim added a commit to redhat-developer/podman-desktop-demo that referenced this issue Feb 15, 2024
@deboer-tim
feat: podman icon
b651e4b 
Just implements the easter egg suggested in containers/podman-desktop#3307.

The frontend is marked with a label, which customizes it with a
Podman icon.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim
Copy link
Collaborator

Fixed via redhat-developer/podman-desktop-demo#37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deboer-tim deboer-tim

Labels
area/demo 🕺 kind/enhancement ✨ Issue for requesting an improvement
Projects
Podman Desktop Planning
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@benoitf @cdrage @deboer-tim @podman-desktop-bot @nichjones1