Navigation doesn't always highlight selection #3509
Assignees
Labels
Comments
deboer-tim
added a commit
that referenced
this issue
Aug 11, 2023
As per issue #3509, the main nav wouldn't show items as selected if they had a space in the URL, or were child pages like settings/resources. This fixes the first issue through URL encoding the href, and the latter by adding back the startsWith() that was special-cased for settings before. New tests added for both cases. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
Aug 15, 2023
As per issue #3509, the main nav wouldn't show items as selected if they had a space in the URL, or were child pages like settings/resources. This fixes the first issue through URL encoding the href, and the latter by adding back the startsWith() that was special-cased for settings before. New tests added for both cases. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
I noticed that the main navigation bar isn't always highlighting the selected item:
Operating system
macOS 13.5
Installation Method
None
Version
next (development version)
Steps to reproduce
Install a Docker extension with a space like 'Disk Usage'. Selecting it or Settings in the main nav won't show the normal purple selection edge.
Relevant log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: