Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncate long usernames in registries page #5670

Closed
vrothberg opened this issue Jan 24, 2024 · 2 comments · Fixed by #5718
Closed

truncate long usernames in registries page #5670

vrothberg opened this issue Jan 24, 2024 · 2 comments · Fixed by #5718
Assignees
Labels
area/dashboard 📊 Concern the dashboard from Container Desktop area/registries kind/enhancement ✨ Issue for requesting an improvement

Comments

@vrothberg
Copy link
Member

Is your enhancement related to a problem? Please describe

Usernames of registry users can be long, especially when machine-generated such as the registry-service accounts used by the Red Hat auth plugin (see redhat-developer/podman-desktop-redhat-account-ext#26). Since names are displayed entirely, it can mess up the interface a bit.

Describe the solution you'd like

Truncate long usernames (maybe even long registries as well) and expand them on demand.

Describe alternatives you've considered

I haven't considered any other alternative.

Additional context

image

@vrothberg vrothberg added the kind/enhancement ✨ Issue for requesting an improvement label Jan 24, 2024
@benoitf benoitf added area/dashboard 📊 Concern the dashboard from Container Desktop area/registries and removed status/need-triage labels Jan 24, 2024
deboer-tim added a commit that referenced this issue Jan 28, 2024
Fixes the unlimited width + long username as shown below or in
issue #5670, by setting a maximum width + no overflow + text
ellipsis. After fixing that I noticed that there is no space
between the columns so the user and password still touch, so I
added space-x-2 in all 4 row groups.

Fixes: #5670.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim self-assigned this Jan 28, 2024
deboer-tim added a commit that referenced this issue Jan 28, 2024
Fixes the unlimited width + long username as shown below or in
issue #5670, by setting a maximum width + no overflow + text
ellipsis. After fixing that I noticed that there is no space
between the columns so the user and password still touch, so I
added space-x-2 in all 4 row groups.

Fixes: #5670.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@vrothberg
Copy link
Member Author

Wow, that was super fast. Thanks a ton, @deboer-tim !

@deboer-tim
Copy link
Collaborator

You made Podman stable on my machine, fixing a minor UI issue is the least I can do. ;-)

deboer-tim added a commit that referenced this issue Jan 29, 2024
While testing #5670 I noticed that the auth page has an identical
issue with long usernames. This just uses a flex row and the same
'text-ellipsis overflow-hidden max-w-64' to ensure long usernames
don't cause UI issues.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim added a commit that referenced this issue Feb 16, 2024
While testing #5670 I noticed that the auth page has an identical
issue with long usernames. This just uses a flex row and the same
'text-ellipsis overflow-hidden max-w-64' to ensure long usernames
don't cause UI issues.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard 📊 Concern the dashboard from Container Desktop area/registries kind/enhancement ✨ Issue for requesting an improvement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants