Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light mode button? #576

Open
cdrage opened this issue Oct 11, 2022 · 12 comments
Open

Light mode button? #576

cdrage opened this issue Oct 11, 2022 · 12 comments
Assignees
Labels
area/dashboard 📊 Concern the dashboard from Container Desktop kind/enhancement ✨ Issue for requesting an improvement

Comments

@cdrage
Copy link
Contributor

cdrage commented Oct 11, 2022

Is your enhancement related to a problem? Please describe

I can't seem to find a button / setting to switch Podman Desktop interface to light mode?

Describe the solution you'd like

I see code such as: ad6f4fc

But I'm unable to find a button or documentation describing how to switch the GUI to light mode.

Describe alternatives you've considered

No response

Additional context

No response

@cdrage cdrage added the kind/enhancement ✨ Issue for requesting an improvement label Oct 11, 2022
@benoitf
Copy link
Collaborator

benoitf commented Oct 11, 2022

It's not yet supported ( waiting UI mockups, etc.)

so in fact the default mode is dark but to turn it to dark mode, all styles should be prefixed by dark:

Website is implementing both light and dark mode (+ a toggle)

@benoitf benoitf added area/dashboard 📊 Concern the dashboard from Container Desktop and removed status/need-triage labels Oct 12, 2022
@SubOptimal
Copy link

I would appreciate light theme support, as dark themes are not suitable for everyone.
I have a problem with colour vision, and the dark themes make it even more difficult for me to use the applications.

@gotmax23
Copy link

I would appreciate light theme support, as dark themes are not suitable for everyone. I have a problem with colour vision, and the dark themes make it even more difficult for me to use the applications.

Indeed. Not having a light mode poses significant accessibility issues.

@nozzlegear
Copy link

I'd also love to see light mode support. It's difficult for me to use this in dark mode due to my own vision problems, and I'd consider them relatively mild.

@markenzie
Copy link

markenzie commented Nov 3, 2023

It's not yet supported ( waiting UI mockups, etc.)

I would be fine even just passing a flag to the startup script or a hidden key combination.

Here is a good article detailing and demonstrating (with slightly exaggerated pictures) how someone with astigmatism views light on dark:

https://bootcamp.uxdesign.cc/why-dark-mode-isnt-a-ux-panacea-1590226e5ba4

image

benoitf added a commit to benoitf/desktop that referenced this issue Nov 20, 2023
there is a new setting which is hidden as if light mode is asked
it will be still displayed with dark theme

But it toggles on or off the dark theme support then we can use
dark: prefix in the codebase to make the style being specific
for the dark theme

related to containers#576

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf self-assigned this Nov 20, 2023
benoitf added a commit that referenced this issue Nov 21, 2023
there is a new setting which is hidden as if light mode is asked
it will be still displayed with dark theme

But it toggles on or off the dark theme support then we can use
dark: prefix in the codebase to make the style being specific
for the dark theme

related to #576

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@deboer-tim deboer-tim mentioned this issue Nov 21, 2023
63 tasks
@Viltersten
Copy link

To be honest (and I'm sorry to sound harsh), I find it nonchalant to fail acting on this request that's been reported 1.5 years ago. No, I don't think it's that hard to create a bright mode version. (It may be suboptimized, possibly distributed separately or such, as long as it's present.) Imagine someone in a wheelchair who can't access a building but no ramp or other workaround is provided. It's legally dubious and definitely wrong ethically.

It's the same with visual impediments. It's not about "make it my preferred color because it's cool". It's about "I can't use the tool because of medical reasons". And before someone arrogantly replies that I'm free to choose another tool, I can tell you that I actually lost a job recently because the employer make a judgement call to only allow Podman. And I simply couldn't work efficiently. It's degrading and discriminating to people with special predisposition.

It should be done better if aspiring to be a serious software vendor.

@benoitf
Copy link
Collaborator

benoitf commented Jan 27, 2024

@Viltersten despite it seems there is no activity there, we worked on making several components in the UI to ensure we'll be able to bring the mode.

We introduced also a flag to make it light mode possible in the future.

And drafted something
#4912

I agree that it's not moving as fast as expected.

@mairin
Copy link
Member

mairin commented Jan 29, 2024

@Viltersten Hey. I'm the lead UX designer involved in the tool, so I feel this is my failing and I want to own it. I don't think anyone from the team would ever dismiss this very legitimate concern arrogantly pointing out that you can use another tool. This is more a combination of two things - I hope it might help in some way to point out, and neither involves a belief this isn't an important and legitimate issue:

  • Unfortunately because of the rapid way the tool developed, there's a quite a bit of copy/paste code that isn´t linked for the UI bits (@deboer-tim has been doing a great job of centralizing and component-izing those UI bits so we can fix this.) Otherwise, we'd have to literally reimplement every page with different CSS to be able to enable light mode. We wanted to do it right.

  • The other thing it's been waiting on is a set of palette color values mapping from dark mode values to light mode values (i think you'll find the issue on here somewhere as a design issue called rosetta stone for lightmode or something like that.) I have work on other projects and have been overwhelmed and this has never quite made it to the top of the priority queue. Before your comment here though, I had assigned coming up with the light mode palette color to my UX teammate Emma and she is coming on board more to help with this project and she's taken on the palette issue this next coming sprint (starting tomorrow), so I really hope we will have some good news for you on this front soon.

I am really very sorry that this has taken so long :( I have astigmatism myself and as of late have been having some challenges with my vision, so to be honest it impacts me as well.

We would also love your (and anyone else interested) feedback on proposed lightmode palettes to make sure they will work well for you. So please let me know if you're willing to test and I'll be sure to reach out when we have something to look at in terms of palette, then something to try when we have something working.

@jameshearttech
Copy link

jameshearttech commented Mar 26, 2024

@mairin I found your latest comment to be sincere, and I think everyone can appreciate your honesty. You mentioned wanting to do it right. On that note, I think it would be best if we were able to select light mode, dark mode, or system (e.g., if system is configured for light mode use light mode).

@deboer-tim
Copy link
Contributor

Correct, that is the plan (and I believe system would be the default).

@greg-hydrogen
Copy link

any update on this? I would love to give it a try if there are any pull requests that I can pull and use I will. I like many can't use the dark theme and I am excited to use this tool when the light theme is ready!

@benoitf
Copy link
Collaborator

benoitf commented Apr 21, 2024

hello @greg-hydrogen there was some progress but it's not yet visible on the UI. (some properties are now used instead of some hardcoded color values). We'll update this ticket once something will be applied on the whole UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard 📊 Concern the dashboard from Container Desktop kind/enhancement ✨ Issue for requesting an improvement
Projects
Status: 📋 Backlog
Development

No branches or pull requests