-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon for Persistent Volume Claim for Kubernetes #7641
Comments
LGTM, but I was assuming the first is 'solid' and the second is 'outline'? We do need both versions for nav/status icons. |
Ahh, that makes sense with regards to colouring. For some reason I thought it was 2 different versions for the navbar. I'm good with that, as I'm assuming the "cake" looking one will be coloured green, yellow, etc. |
Here's what it'll look like in context, I will PR as soon as #7640 gets merged: ![]() I almost want to say the dashing could be a little more pronounced - but honestly it is great as-is. And actually @ekidneyrh , would you mind redoing the regular solid volume icon with the 'outline' like above? The solid PVC stands out so much nicer I think we should do it here too: ![]() |
Lol yah it's for the solid one! It was tricky to have the dashes still visible but also have it filled in. I can do that :) I'll add onto this ticket |
Adds a PVC icon as per design. Fixes containers#7641. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Updated solid volume icon. IMHO this version stands out (pops) better and is a little clearer on the solid background, plus it will match with the PVC icon (PR incoming) that really requires the full outline. Raised as part of containers#7641. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Updated solid volume icon. IMHO this version stands out (pops) better and is a little clearer on the solid background, plus it will match with the PVC icon (PR incoming) that really requires the full outline. Raised as part of containers#7641. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Adds a PVC icon as per design. Fixes containers#7641. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Updated solid volume icon. IMHO this version stands out (pops) better and is a little clearer on the solid background, plus it will match with the PVC icon (PR incoming) that really requires the full outline. Raised as part of containers#7641. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Adds a PVC icon as per design. Fixes containers#7641. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Updated solid volume icon. IMHO this version stands out (pops) better and is a little clearer on the solid background, plus it will match with the PVC icon (PR incoming) that really requires the full outline. Raised as part of #7641. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Updated solid volume icon. IMHO this version stands out (pops) better and is a little clearer on the solid background, plus it will match with the PVC icon (PR incoming) that really requires the full outline. Raised as part of containers#7641. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Adds a PVC icon as per design. Fixes containers#7641. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Is your enhancement related to a problem? Please describe
We should have an icon that's different than the normal "volumes" icon for PVC. Right now in the PR it is re-using the volume icon: #7640
Taken from google, I was thinking something like this?
It makes sense for it to be a "dashed" volume since it's "claiming".
Describe the solution you'd like
Icon for PVC
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: