Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for Persistent Volume Claim for Kubernetes #7641

Closed
cdrage opened this issue Jun 13, 2024 · 8 comments · Fixed by #7710
Closed

Icon for Persistent Volume Claim for Kubernetes #7641

cdrage opened this issue Jun 13, 2024 · 8 comments · Fixed by #7710
Assignees
Labels

Comments

@cdrage
Copy link
Contributor

cdrage commented Jun 13, 2024

Is your enhancement related to a problem? Please describe

We should have an icon that's different than the normal "volumes" icon for PVC. Right now in the PR it is re-using the volume icon: #7640

Taken from google, I was thinking something like this?

image

It makes sense for it to be a "dashed" volume since it's "claiming".

Describe the solution you'd like

Icon for PVC

Describe alternatives you've considered

No response

Additional context

No response

@ekidneyrh
Copy link
Contributor

SVGs:
pvc
pvc-filled

PNGs:
pvc-filled
pvc

Here's a screenshot from inkscape for better visibility :)

image

WDYT?

@cdrage
Copy link
Contributor Author

cdrage commented Jun 17, 2024

SVGs: pvc pvc-filled

PNGs: pvc-filled pvc

Here's a screenshot from inkscape for better visibility :)

image

WDYT?

Looks good to me (the second one)! The first one to me looks like a fancy cake since it has the black outline / white dotted inside.

@deboer-tim
Copy link
Collaborator

Looks good to me (the second one)! The first one to me looks like a fancy cake since it has the black outline / white dotted inside.

LGTM, but I was assuming the first is 'solid' and the second is 'outline'? We do need both versions for nav/status icons.

@cdrage
Copy link
Contributor Author

cdrage commented Jun 17, 2024

Ahh, that makes sense with regards to colouring. For some reason I thought it was 2 different versions for the navbar. I'm good with that, as I'm assuming the "cake" looking one will be coloured green, yellow, etc.

@deboer-tim
Copy link
Collaborator

Here's what it'll look like in context, I will PR as soon as #7640 gets merged:

Screenshot 2024-06-17 at 4 09 02 PM

I almost want to say the dashing could be a little more pronounced - but honestly it is great as-is.

And actually @ekidneyrh , would you mind redoing the regular solid volume icon with the 'outline' like above? The solid PVC stands out so much nicer I think we should do it here too:

Screenshot 2024-06-17 at 4 15 33 PM

@ekidneyrh
Copy link
Contributor

Lol yah it's for the solid one! It was tricky to have the dashes still visible but also have it filled in. I can do that :) I'll add onto this ticket

@ekidneyrh
Copy link
Contributor

SVG:
volume-filled

Preview from inkscape:
image

@deboer-tim
Copy link
Collaborator

Thanks! I do like this better and will PR at the same time as PVC.

Screenshot 2024-06-18 at 7 58 35 AM

deboer-tim added a commit to deboer-tim/desktop that referenced this issue Jun 18, 2024
Adds a PVC icon as per design.

Fixes containers#7641.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim added a commit to deboer-tim/desktop that referenced this issue Jun 18, 2024
Updated solid volume icon. IMHO this version stands out (pops) better
and is a little clearer on the solid background, plus it will match
with the PVC icon (PR incoming) that really requires the full outline.

Raised as part of containers#7641.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim added a commit to deboer-tim/desktop that referenced this issue Jun 18, 2024
Updated solid volume icon. IMHO this version stands out (pops) better
and is a little clearer on the solid background, plus it will match
with the PVC icon (PR incoming) that really requires the full outline.

Raised as part of containers#7641.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim added a commit to deboer-tim/desktop that referenced this issue Jun 18, 2024
Adds a PVC icon as per design.

Fixes containers#7641.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim added a commit to deboer-tim/desktop that referenced this issue Jun 18, 2024
Updated solid volume icon. IMHO this version stands out (pops) better
and is a little clearer on the solid background, plus it will match
with the PVC icon (PR incoming) that really requires the full outline.

Raised as part of containers#7641.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim added a commit to deboer-tim/desktop that referenced this issue Jun 18, 2024
Adds a PVC icon as per design.

Fixes containers#7641.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
cdrage pushed a commit that referenced this issue Jun 18, 2024
Updated solid volume icon. IMHO this version stands out (pops) better
and is a little clearer on the solid background, plus it will match
with the PVC icon (PR incoming) that really requires the full outline.

Raised as part of #7641.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
cdrage pushed a commit to cdrage/podman-desktop that referenced this issue Jun 19, 2024
Updated solid volume icon. IMHO this version stands out (pops) better
and is a little clearer on the solid background, plus it will match
with the PVC icon (PR incoming) that really requires the full outline.

Raised as part of containers#7641.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
cdrage pushed a commit to cdrage/podman-desktop that referenced this issue Jun 19, 2024
Adds a PVC icon as per design.

Fixes containers#7641.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants