Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension-api): allow to specify enum type for configuration items #1059

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Dec 19, 2022

What does this PR do?

extension/internal components can provide enum type for properties

Screenshot/screencast of this PR

KegoYh8ZqE.mp4

What issues does this PR fix or reference?

Related to #413

How to test this PR?

Add into an extension enum type

example for podman extension in package.json/contributes

        "podman.factory.example": {
          "type": "string",
          "default": "foo",
          "scope": "ContainerProviderConnectionFactory",
          "description": "Name",
          "enum": ["foo", "bar", "baz"]
        },

Change-Id: I69b2c00642cc9b1162add7090e7f95974ba143f2
Signed-off-by: Florent Benoit fbenoit@redhat.com

Change-Id: I69b2c00642cc9b1162add7090e7f95974ba143f2
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and see no errors, tested it out using contributes and it works fine!

@cdrage cdrage merged commit d18e14c into containers:main Dec 19, 2022
@podman-desktop-bot podman-desktop-bot added this to the 0.11.0 milestone Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants