feat: add airgap binaries embedding the Podman images #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
force-pushed
the
DESKTOP-185
branch
5 times, most recently
from
61c2f1c
to
505fd9e
Compare
- on mac, it embeds the qemu FCOS binaries - on Windows, it embeds the WSL binary When initializing a new podman machine using airgap binaries it'll use the embedded files and not grab it from internet There is also an optional way to provide a custom image in the create menu Change-Id: I0b250ae2e018ff56eda1d2170fd91ab8cfc52eae Signed-off-by: Florent Benoit <fbenoit@redhat.com>
cdrage
approved these changes
Jan 10, 2023
|
Confirmed that it worked! LGTM |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Publish new 'airgap' binaries on releases (not the pre-releases)
they're containing 'airgap' in their artifactname and are bigger.
When initializing a new podman machine using airgap binaries it'll use the embedded files and not grab it from internet
There is also an optional way to provide a custom image in the create menu
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes #185
How to test this PR?
You can test a binary setting env variable AIRGAP_DOWNLOAD
for example:
and then test the binary produced in
dist/folder (for example on mac, the generated dmg should be around 1.5GB in size)Change-Id: I0b250ae2e018ff56eda1d2170fd91ab8cfc52eae
Signed-off-by: Florent Benoit fbenoit@redhat.com