fix: invalid badge count for images #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if 2 images have the same tag we display two lines in images list badge count should take that into account fixes containers#1101 Change-Id: I9de232f51c2fa0a0811543225590fd13026ba8ec Signed-off-by: Florent Benoit <fbenoit@redhat.com>
cdrage
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
if 2 images have the same tag we display two lines in images list badge count should take that into account
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes #1101
How to test this PR?
perform:
check you have a badge count of 2 and not 1
Change-Id: I9de232f51c2fa0a0811543225590fd13026ba8ec
Signed-off-by: Florent Benoit fbenoit@redhat.com