Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: statistics area in container details #1131

Merged
merged 1 commit into from Jan 9, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Jan 6, 2023

What does this PR do?

  • fix random appear/disappear (was the case if cpuUsage or memoryUsage was 0)

fix other bugs around it

  • always view the bars
  • add initializing text field when we're collecting data
  • display current memory as well on the right

Screenshot/screencast of this PR

jAm8wITWDQ.mp4

What issues does this PR fix or reference?

Fixes #495
Fixes #505

How to test this PR?

Start a container and goes to container's details view.

also add values of memory of CPU
Fixes containers#495
Fixes containers#505

Change-Id: I0b1459d73658190a98636218be18fae38d8818b9
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to test this out and it works well! Approving (feel free to merge whenever)

@benoitf benoitf merged commit f740b33 into containers:main Jan 9, 2023
@podman-desktop-bot podman-desktop-bot added this to the 0.11.0 milestone Jan 9, 2023
@slemeur
Copy link
Collaborator

slemeur commented Jan 9, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Memory and CPU values Container stats randomly appear & disappear
4 participants