feat(dd-extension-api): Implement toast API #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes containers#772 Change-Id: I924f96229585fbd146fda19aa93386dae38a7d45 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
LGTM. Was able to test this out perfectly with the OpenShift extension. |
|
@cdrage looks like you didn't approve :-) |
cdrage
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements toast API of docker desktop extensions
Screenshot/screencast of this PR
O5HDN7dJHc.mp4
What issues does this PR fix or reference?
fixes #772
How to test this PR?
1.Adds OpenShift extension
2.click on reload button (success notification/toast)
3. Click on login into a cluster and provides fake URL like http://127.0.0.1:1234 (error notification/toast)
Change-Id: I924f96229585fbd146fda19aa93386dae38a7d45
Signed-off-by: Florent Benoit fbenoit@redhat.com