feat: Better feedback for containers that exit immediately #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes containers#504 Change-Id: Iadc90864dab9bd77d7efd4b11ca0867e823ec883 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
cdrage
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following the fix for #1013, add feedback for the details of containers as well.
Include report of error and for short-lived containers
Screenshot/screencast of this PR
CJdc0nwXaD.mp4
What issues does this PR fix or reference?
fixes #504
How to test this PR?
In Container list, start for example quay.io/podman/hello multiple times. Icons and status is changed to STARTING
Go to details of a page, you can see spinner and status changing as well when starting again the container
Change-Id: Iadc90864dab9bd77d7efd4b11ca0867e823ec883
Signed-off-by: Florent Benoit fbenoit@redhat.com