fix: UI alignment issues in page tables #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the following issues: - Creation date sometimes appeared on two lines: add whitespace-nowrap - Creation date header didn't line up with column: remove header centering, fix padding to match cell, and remove cell left margin. - Name header centered on Images and Volumes page but not others: removed centering on these page. - Container list column sizes change when you start a container, and when the width of the age text changes: use w-10 for name column so only age column changes width. Signed-off-by: Tim deBoer <git@tdeboer.ca>
|
Should we change "Creation Date" to "Age" while were at it so it's similar code-wise to the Otherwise, this LGTM! Tested and viewed it. All looks good to me. |
|
FWIW, I couldn't find any design guidance that would lean towards either, and I think there's a slight semantic difference between age and creation date and how we're using it today - i.e. age is only used for how long a container has been running, not when it was created. My preference would be to merge, and I'm happy to change it later if there's agreement. |
benoitf
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the following UI issues on the main page tables, with explanation of each fix:
Screenshot/screencast of this PR
One example - others should be obvious enough. Before:
After:
