chore: improve SVG icon styling #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After learning a bit more Svelte this looks like a cleaner way to pass styling down to the SVG icon components: - Size isn't restricted to a number but can be 1em, or 10%. - SVG now correctly inherits styling (e.g. color) from its parent, or can be set explicitly. Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
approved these changes
Jan 24, 2023
benoitf
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After learning a bit more Svelte this looks like a cleaner way to pass styling down to the SVG icon components:
Screenshot/screencast of this PR
N/A. No visible change, but will make it easier/possible to reuse the icons in other places.