feat: add ability to manually set color of tray icon for Windows and Linux #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
force-pushed
the
force-tray-icon-colour
branch
from
12e7637
to
e2f9325
Compare
benoitf
reviewed
Jan 25, 2023
benoitf
reviewed
Jan 25, 2023
benoitf
reviewed
Jan 25, 2023
packages/renderer/src/lib/preferences/PreferencesRenderingItemFormat.svelte
Show resolved
Hide resolved
cdrage
force-pushed
the
force-tray-icon-colour
branch
2 times, most recently
from
ba2ce32
to
09e9d4e
Compare
benoitf
reviewed
Jan 25, 2023
benoitf
reviewed
Jan 25, 2023
|
Updated:
|
benoitf
reviewed
Jan 25, 2023
cdrage
force-pushed
the
force-tray-icon-colour
branch
from
09e9d4e
to
34be7ac
Compare
benoitf
changed the title
cdrage
force-pushed
the
force-tray-icon-colour
branch
from
c2e2b56
to
a5ebeb1
Compare
### What does this PR do? * Allows the ability to set the default 'theme' of the icon to either light (black icon) or dark (white icon). __NOTE:__ This does not work on Mac, because if you set the theme to 'light' to display a black icon, macOS will automatically detect it is an all-black icon, and invert the colours to white. ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes containers#980 ### How to test this PR? 1. Compile / yarn watch on Windows 2. Change the setting 3. Restart podman desktop and view the icon on the taskbar. <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
force-pushed
the
force-tray-icon-colour
branch
from
a5ebeb1
to
0078b80
Compare
benoitf
approved these changes
Jan 25, 2023
benoitf
changed the title
slemeur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add ability to manually set colour of icon
What does this PR do?
light (black icon) or dark (white icon).
NOTE: This does not work on Mac, because if you set the theme to
'light' to display a black icon, macOS will automatically detect it is
an all-black icon, and invert the colours to white.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Closes #980
How to test this PR?
Signed-off-by: Charlie Drage charlie@charliedrage.com