fix: needs to wait that telemetry has been initilized before proceeding #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I075f6244bf959e1339fa81756d9c50410771cfbe Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
cdrage,
jeffmaury,
lstocchi and
vzhukovs
as code owners
|
I'm not an approver, but LGTM. |
cdrage
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix potential erroneous anonymousId if the file is not present on the filesystem
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Erroneous data
How to test this PR?
Remove ~/.redhat (or keep your existing data to make it back again)
remove ~/.local/share/containers/podman-desktop/configuration/settings.json (or just make sure telemetry is enabled/telemetry is not asked)
check that we send the same anonymousId and not multiple one
Change-Id: I075f6244bf959e1339fa81756d9c50410771cfbe
Signed-off-by: Florent Benoit fbenoit@redhat.com