fix: new xterm instance spawn when clicking the logs route in pod details (#1355) #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails (containers#1355) Signed-off-by: luca <lstocchi@redhat.com>
lstocchi
requested review from
cdrage,
jeffmaury,
vzhukovs and
benoitf
as code owners
cdrage
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR prevents creating multiple xterm instances. The same fix as #1344 for Pod logs
Screenshot/screencast of this PR
N/A
To view the issue it is the same as it was for containers https://user-images.githubusercontent.com/49404737/216112655-feb626cd-db72-4b78-a0eb-6f91b153c863.gif
What issues does this PR fix or reference?
it fixes #1355
How to test this PR?