Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop spinner if image cannot be retrieved (#1354) #1394

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix: stop spinner if image cannot be retrieved (#1354) #1394

merged 1 commit into from
Feb 7, 2023

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Feb 7, 2023

What does this PR do?

it stops the spinner from the install button if the image cannot be retrieved

Screenshot/screencast of this PR

stop-spinner-install-ext

What issues does this PR fix or reference?

it fixes #1354

How to test this PR?

  1. Go to settings -> Desktop extensions
  2. Add the name of a not existing image
  3. Try installing it. When failing you should be able to click the button again

cdrage
cdrage approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM!

@lstocchi
fix: stop spinner if image cannot be retrieved (containers#1354)
eaf99f9 
Signed-off-by: luca <lstocchi@redhat.com>
jeffmaury
jeffmaury requested changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows and LGTM.
However, one check is failing, you probably need to run format:fix

@lstocchi
Copy link
Contributor Author

lstocchi commented Feb 7, 2023

@jeffmaury done, now it should be green 🤞

jeffmaury
jeffmaury approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now :)

@lstocchi lstocchi merged commit 9ed0a7c into containers:main Feb 7, 2023
@lstocchi lstocchi deleted the i1354 branch February 7, 2023 17:18
@podman-desktop-bot podman-desktop-bot added this to the 0.12.0 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@jeffmaury jeffmaury jeffmaury approved these changes

@cdrage cdrage cdrage approved these changes

@vzhukovs vzhukovs Awaiting requested review from vzhukovs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Spinner never ends if Docker extension image cannot be retrieved
5 participants
@lstocchi @benoitf @jeffmaury @cdrage @podman-desktop-bot