Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable/disable open browser action based on container state (#1348) #1395

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Feb 7, 2023

What does this PR do?

enable/disable open browser action based on container state

Screenshot/screencast of this PR

open-browser-button

What issues does this PR fix or reference?

it fixes #1348

How to test this PR?

  1. open a container
  2. check that the open in browser is not enabled
  3. start the container
  4. the open browser should be enabled
  5. stop it, check again ...

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested on Windows

Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS! LGTM

@cdrage cdrage merged commit 72d15f8 into containers:main Feb 8, 2023
@podman-desktop-bot podman-desktop-bot added this to the 0.12.0 milestone Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Open Browser' in container details is not enabled/disabled correctly
4 participants