Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide open browser action in kebab menu for stopped container (#1347) #1397

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Feb 8, 2023

What does this PR do?

it hides the open browser action for stopped container within the kebab menu

Screenshot/screencast of this PR

open-browser-kebab-menu

What issues does this PR fix or reference?

it fixes #1347

How to test this PR?

  1. start a container, check that the open browser action is visible in the kebab menu
  2. stop it, the action is not visible anymore

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested on Windows

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstocchi lstocchi merged commit ab024ee into containers:main Feb 8, 2023
@lstocchi lstocchi deleted the i1347 branch February 8, 2023 19:20
@podman-desktop-bot podman-desktop-bot added this to the 0.12.0 milestone Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Open Browser' action should not be present in kebab menu when container is stopped
4 participants