check for flatpak when calling command from exec #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg S <97077423+RobotSail@users.noreply.github.com>
RobotSail
requested review from
cdrage,
jeffmaury,
lstocchi,
vzhukovs and
benoitf
as code owners
|
I'm not sure if this is the best approach; I'm simply following what's happening in the Podman extension extensions/podman/src/util.ts |
benoitf
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue where commands cannot be executed on system when running within a Flatpak.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
When running commands within an extension, they all are spawned on the system the same way.
However, running the same commands when Podman desktop is running as a Flatpak will cause the extension to break with the following error message:
Flatpak
Non-Flatpak
How to test this PR?
Try running the FetchIt Desktop extension from within a Flatpak environment and then outside of Flatpak.