Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check and refresh Podman container engine connection on Windows/Mac (#1446) #1662

Merged
merged 2 commits into from
Mar 13, 2023
Merged

fix: check and refresh Podman container engine connection on Windows/Mac (#1446) #1662

merged 2 commits into from
Mar 13, 2023

Conversation

lstocchi
Copy link
Contributor

What does this PR do?

This is the part related to Windows/Mac of #1446. The Linux PR was #1590
This adds a periodic check on the podman socket so that the dashboard is updated accordingly

Screenshot/screencast of this PR

windows-socket

What issues does this PR fix or reference?

it resolves #1446

How to test this PR?

  1. login into your podman machine. wsl -d podman-machine-default in my case
  2. remove temporarily the socket file in /run/user/$UID/podman/
  3. the dashboard should refresh
  4. add it again
  5. the dashboard should display resources as before

@lstocchi lstocchi requested review from a team and benoitf as code owners March 13, 2023 08:25
@lstocchi lstocchi requested review from jeffmaury and vzhukovs and removed request for a team March 13, 2023 08:25
@lstocchi
fix format
186cdad 
Signed-off-by: luca <lstocchi@redhat.com>
benoitf
benoitf approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried on a podman machine on mac

$ podman machine ssh
$ cd /run/user/501/podman
$ mv podman.sock podman-old.sock

UI is refreshed (containers are gone)

move back the file

UI is refreshed (containers are back)

cdrage
cdrage approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to test this on M1 and it works as expected. The code LGTM. Had no issues running it. Thanks @lstocchi

@cdrage cdrage merged commit ea95e56 into containers:main Mar 13, 2023
@podman-desktop-bot podman-desktop-bot added this to the 0.13.0 milestone Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@cdrage cdrage cdrage approved these changes

@jeffmaury jeffmaury Awaiting requested review from jeffmaury jeffmaury is a code owner automatically assigned from containers/podman-desktop-reviewers

@vzhukovs vzhukovs Awaiting requested review from vzhukovs vzhukovs is a code owner automatically assigned from containers/podman-desktop-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

Check/validate/refresh container engine connection
4 participants
@lstocchi @benoitf @cdrage @podman-desktop-bot