fix: rename variable to fix register tray item

[evidolob]

What does this PR do?

It fix registration of provider tray menu, by properly sending providerId.
And, also, fix deleting/removing provider menu item, as Disposable which created upon registration is not remove command from tray itself.

As TrayMenu expects to receive object with field providerId , but we send providerName.

Screenshot/screencast of this PR

Without this fix, any tray provider menu item added in to temp sub menu:

With this fix tray menu item adde to proper provider sub menu:

What issues does this PR fix or reference?

n/a

How to test this PR?

In your extension use extensionApi.tray.registerProviderMenuItem function to register command for your provider,
ensure that your command is on proper sub menu of tray menu. (i.e. no under temp menu item)

[benoitf]

works as expected

do you think you could add a unit test ?

we're now trying to beg for unit tests upon bug fixes or new features

[gbraad]

While I agree about unit tests, it might need a lot of additional mock to make this work now. Wonder if it is worth the roi at this time. May we park this for later (tech debt)? I'll let Yevhen decide on this.

[evidolob]

@benoitf

I add test, and also provide fix for deleting provider menu item.

Could you review again?

[benoitf]

just small typo on the date

[gbraad]

We used to run a check for this on CI... which meant every 1st of Jan you would have failing builds and a big changeset with string replacements for the date ;-)