fix(updates): Rework update mechanism #1827
Merged
+154
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure that when we check for updates, we do not download artifacts - ensure that we're event based - ask the user if he wants to restart Podman Desktop once the update has been successfully downloaded fixes containers#1806 Change-Id: Ib6f7460db601bdae7f17758b52af506a207789b6 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
jeffmaury and
cdrage
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While trying the update, it was working but user got several error messages
Now:
Screenshot/screencast of this PR
AzkI3jELjs.1.mp4
What issues does this PR fix or reference?
Fixes #1806
How to test this PR?
I don't know how to test the PR on your own as it's requiring signed binaries
I did some signed binaries for macOS there:
https://github.com/benoitf/desktop/releases/tag/v0.2.15
it's a faked Podman Desktop test
v0.2.15app that will ask you to update to av0.2.210version