feat: add compatibility enable / disable button for Linux #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
jeffmaury and
lstocchi
and removed request for
a team
cdrage
force-pushed
the
linux-compat-button
branch
2 times, most recently
from
0619837
to
dbfa15b
Compare
cdrage
force-pushed
the
linux-compat-button
branch
17 times, most recently
from
263cf7a
to
eb784b9
Compare
### What does this PR do? * Adds a compatibility button that will enable / disable the systemd podman.socket that allows Docker compatibility * Refactors the runSudoHelperCommand function so that both macOS and Linux implementations can use it containers#1769 should be merged before this goes in as there will be rebasing / conflicts ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes the rest of containers#1447 ### How to test this PR? <!-- Please explain steps to reproduce --> 1. Use Linux 2. `yarn watch` 3. Click on the compatibility mode and follow the steps to enable / disable. Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
force-pushed
the
linux-compat-button
branch
from
eb784b9
to
4b733c0
Compare
|
Ready for review, but I'm honestly not sure if we can merge this in until #1912 is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add compatibility enable / disable button for Linux
What does this PR do?
podman.socket that allows Docker compatibility
Linux implementations can use it
#1769 should be merged
before this goes in as there will be rebasing / conflicts
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Closes the rest of #1447
How to test this PR?
yarn watchyarn compile --linux=flatpakand install / run the flatpak., this is due to issue Compatibility mode does not work onyarn watchpermission denied /var/run/docker.sock #1912disable.
Signed-off-by: Charlie Drage charlie@charliedrage.com