-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend withProgress API to use task manager widget #2187
Conversation
Fixes containers#2019 Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Don't see any issues with the code and was able to test it fine.
Feel free to merge whenever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should not remove ProgressLocation for APP_ICON but that's a different story.
It's not related to the withProgress API implementation using tasks but it seems the message that we display for kind is not accurate
We display in one side that we've downloaded kind but task is at 80% waiting that we install or not the binary in the PATH but the title is 'Downloading kind' so this task is over and it should be 100%
Or task should be 'Installing Kind' or two tasks I don't know but here it feels inconsistent.
7VRu3RXaZY.mp4
I discussed with @evidolob and we choose to keep APP_ICON for a while. Maybe we should mark it deprecated and remove it after 0.15.0 ? Will update the implementation so that a completed task is always 100% |
I'm +1 to keep |
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #2019
What does this PR do?
Extend the withProgress API to report progress in the task API
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes #2019
How to test this PR?
Re install Kind and Kind download should be reported in the task manager