fix: menus are not unregistered upon extension deactivation #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes containers#2069 Signed-off-by: Jeff MAURY <jmaury@redhat.com>
jeffmaury
requested review from
cdrage and
lstocchi
and removed request for
a team
lstocchi
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
LGTM
my only concern is that we should add some rule to avoid duplicate commands. I think it's possible that two extensions contribute to the same menu with two command having the same name. In that case one will overwrite the other.
BTW this fixes our current issue, this is why i gave my LGTM, not sure if you want to fix this other thing in another PR.
cdrage
approved these changes
Apr 21, 2023
benoitf
reviewed
Apr 24, 2023
Comment on lines
800
to
811
|
|
||
| const analyzedExtension = this.analyzedExtensions.get(extensionId); | ||
| if (analyzedExtension) { | ||
| const extensionConfiguration = analyzedExtension.manifest?.contributes?.configuration; | ||
| if (extensionConfiguration) { | ||
| this.configurationRegistry.deregisterConfigurations([extensionConfiguration]); | ||
| } | ||
| const menus = analyzedExtension.manifest?.contributes?.menus; | ||
| if (menus) { | ||
| this.menuRegistry.unregisterMenus(menus); | ||
| } | ||
| } |
There was a problem hiding this comment.
probably need to move this upper before we delete it from activated extensions ?
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
benoitf
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2069
What does this PR do?
Unregister contributed menus when extension is stopped
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes #2069
How to test this PR?
Stop and start Kind extension and make sure the Push to cluster menu appears only once on the Images tab