Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): Add a markdown component to render markdown content inside Podman Desktop #2219

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Apr 25, 2023

What does this PR do?

Introduce a markdown rendering component using the smallest markdown library (micromark)

Also add a custom component to generate button from links using the micromark extension micromark-extension-directive

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

required for #2152

How to test this PR?

I've added component tests that check that markdown is correctly outputted

… Podman Desktop

required for containers#2152

Change-Id: I56342e15cf24a9e72841202cd21b5cb5c47eb048

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Change-Id: I99c00cb2a8f27172f29b0b207ee6f0973f9b916b
@benoitf benoitf requested a review from a team as a code owner April 25, 2023 14:36
@benoitf benoitf requested review from jeffmaury and lstocchi and removed request for a team April 25, 2023 14:36
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants