feat: Allow to install in one click featured extensions (if not installed) #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
jeffmaury and
lstocchi
and removed request for
a team
lstocchi
reviewed
May 5, 2023
There was a problem hiding this comment.
II see this error when fetching the catalog Unable to fetch the available extensions: Timeout awaiting 'lookup' for 1000ms and it results in the N/A status. Not sure what we can do to improve it but if that happens, what's the point of showing the crc/openshift local extension if i cannot do anything?
Other point is that the icon of the extension are not high quality - look at the podman/lima/local icons. We should update them
| Here is the default settings maybe it's too short for your internet connection. |
yes, by increasing it it worked fine. |
|
need to find the good limit then |
|
#2346 has been merged now, so we will need to rebase |
|
@cdrage rebased |
…lled) related to containers#1901 widget available from dashboard page and extensions list Change-Id: I495ad06dd7f27a3779195c3fc503dae3dd6e0cc3 Signed-off-by: Florent Benoit <fbenoit@redhat.com> Change-Id: I1559329c48dd4d9390e133d8ddcf647340dded92
|
I'll open follow-up PRs for timeouts and icons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
What does this PR do?
Display a widget in dashboard and extensions list to install featured extension in one click
Screenshot/screencast of this PR
62PolDwZOo.mp4
What issues does this PR fix or reference?
related to #1901
How to test this PR?
It requires commits from
There are component tests
How to test: Launch Podman Desktop (and check that for example you don't already have SandBox or OpenShift Local being installed)
Then click on the download icon and wait a little, then extension should be there
Change-Id: I495ad06dd7f27a3779195c3fc503dae3dd6e0cc3