feat: Use our own titlebar to avoid double titlebars on Linux/Windows #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes containers#1805 Change-Id: I3672a85cf7d777e8744e311e2b9a5abb75aa5c02 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
jeffmaury
approved these changes
May 9, 2023
|
Tested on Mac M1, LGTM. |
|
@cdrage so if you can test it under Linux |
|
Under Linux: #1802 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I3672a85cf7d777e8744e311e2b9a5abb75aa5c02
What does this PR do?
Avoid double title bars on Windows and Linux
Screenshot/screencast of this PR
example on Windows now:
What issues does this PR fix or reference?
fixes #1805
How to test this PR?
Created so we can get feedback / comments