chore: reduce initial REST API calls #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
force-pushed
the
DESKTOP-2375
branch
2 times, most recently
from
b056432
to
80584c5
Compare
benoitf
requested review from
jeffmaury and
cdrage
and removed request for
a team
jeffmaury
reviewed
May 10, 2023
Change-Id: I4cd5baec2269e080d2323f79d2f89cc52ac07966 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
During startup, lot of extensions can be started, etc so we don't try to refresh on every extension start, just when all extensions are loaded It reduces the number of initial calls to populate the store Change-Id: I94f2235a411ec9633300c813134f3a2d4e3b46ae Signed-off-by: Florent Benoit <fbenoit@redhat.com>
fetch them only if user click on the volumes tab Grabbing volumes with their size can take a while so initial call is only if we ask for it. Change-Id: Ie8f24c6f7aa5adae6c8d1644884232654a6931bb Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When Podman Desktop starts, it tries to fetch and refresh data like containers, images, volumes, pods a lot of time.
For example after an extension is started, etc.
But podman REST API has no cache and getting volume data like the size can take 5+s
so, instead of that, performs only one fetch for containers, images and pods when Podman Desktop is started
and then for volumes, first initialization occurs only if we ask for it.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Fixes #2375
Fixes #2310
Fixes #2259
How to test this PR?
Unit tests
but also try to use Podman Desktop with large images/volumes
Change-Id: I761f508ff3389a1253fb3ff273a84bb586d1c391