fix: do not rely on socket path for unicity #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
jeffmaury and
cdrage
and removed request for
a team
before podman 4.5, socket path were different for all machines with podman 4.5, socket path is the same for all the machines so some functions were using the path as a key then it leads to lot of errors with invalid data, failure to get the right machine, duplicated things, config from other machines, etc. fixes containers#2338 Change-Id: I76e23b1cc2656e6fd61d60a265d0b93698f7196d Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
before podman 4.5, socket path were different for all machines with podman 4.5, socket path is the same for all the machines
so some functions were using the path as a key
then it leads to lot of errors with invalid data, failure to get the right machine, duplicated things, config from other machines, etc.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes #2338
How to test this PR?
Create like 5 podman machines with different cpu/memory/disk/etc.
before PR:
Use multiple machines and go to the settings page.
cpu, memory being displayed are the same for machines even if they have different values
All machines might be RUNNING or all Stopped
Tray menu only display one machine
etc.
After
Change-Id: I76e23b1cc2656e6fd61d60a265d0b93698f7196d