Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear previous error when installing extension #2469

Merged
merged 1 commit into from
May 15, 2023

Conversation

deboer-tim
Copy link
Collaborator

What does this PR do?

Title says it all, clear the previous error. Matches code already in the other extension path.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Fixes #2463.

How to test this PR?

Try to install a Docker Desktop extension with an incorrect name, then try a valid one.

Title says it all, clear the previous error. Matches code already in the other extension path.

Fixes containers#2463.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim requested review from a team and benoitf as code owners May 11, 2023 16:30
@deboer-tim deboer-tim requested review from jeffmaury and cdrage and removed request for a team May 11, 2023 16:30
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May require a unit test to validate error field is cleared out

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deboer-tim deboer-tim merged commit 9142c99 into containers:main May 15, 2023
7 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 0.16.0 milestone May 15, 2023
@deboer-tim deboer-tim deleted the grafana branch June 6, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nit: previous error persists in extensions view after a successful download
5 participants