Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add example image name in placeholder #2567

Conversation

tuckerrc
Copy link
Contributor

What does this PR do?

Adds an example image name (with registry url) to the Image Name field of the build image form.

Screenshot/screencast of this PR

Screenshot 2023-05-19 at 1 37 00 PM

What issues does this PR fix or reference?

Closes: #2251

How to test this PR?

  1. Navigate to the Image view
  2. Click the "Build an Image" button on the top right
  3. Clear the default image name ("my-custom-image")
  4. See the placeholder text

@tuckerrc tuckerrc requested review from a team and benoitf as code owners May 19, 2023 18:16
@tuckerrc tuckerrc requested review from jeffmaury and cdrage and removed request for a team May 19, 2023 18:16
Signed-off-by: Tucker Chapman <tucker.r.chapman@gmail.com>
@tuckerrc tuckerrc force-pushed the tuckerrc/2251/image-name-example-in-placeholder branch from 22688de to 38fb59a Compare May 19, 2023 18:24
@benoitf
Copy link
Collaborator

benoitf commented May 21, 2023

thanks @tuckerrc

@benoitf benoitf enabled auto-merge (rebase) May 21, 2023 08:31
@benoitf benoitf merged commit 109d3ba into containers:main May 21, 2023
7 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.1.0 milestone May 21, 2023
@benoitf benoitf modified the milestones: 1.1.0, 1.0.1 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve instructions on build image form to better enable pushing images
3 participants